Z

Zap

Mon, 04 May 2020 01:19:50 -0700

Einer von Vielen wrote the following post Mon, 04 May 2020 01:19:50 -0700

Own permission for new addon
@Mike Macgirvin @Mario Vavti Please could you give me some advice.

What I would like to have: A permission "view_myaddon" analogue to
perm_is_allowed($owner_uid, get_observer_hash(), 'view_storage')

Is it possible?
If yes, could you please give me some hints how to do it.

Background
I would like to change the permission system of the addon faces. The current implementation works but should be improved and simplified.

My plans

Use "view_faces" to allow / block an observer to open the addon of a channel owner.
table faces_encoding: Do not use explicit permissions (anymore). All encodings should use the permission of the image it belongs to.
table faces_name: Every name should have an individual permission, or, if not set, use "view_faces".

show all 5 comments

Mike Macgirvin

Mon, 04 May 2020 02:38:30 -0700

'perm_is_allowed' is a hook that can be caught by an addon and used to control any permission you want, even those that aren't already defined. See include/permissions.php::perm_is_allowed().

Einer von Vielen

Tue, 05 May 2020 03:05:26 -0700

I see. Thanks.

Where would you store the permission?

To use...

if (!perm_is_allowed($owner_uid, get_observer_hash(), 'view_faces')) {
    // not allowed
}

I use...

function faces_load() {
    Hook::register('perm_is_allowed', 'addon/faces/faces.php', 'faces_perm_is_allowed');
}

function faces_perm_is_allowed(&$a) {
    $uid = $a['channel_id'];
    $obs_hash = $a['observer_hash'];
    $permission = $a['permission']; // 'view_faces'
    if ($permission == 'view_faces') {
        $a['result'] = 1;
    }
}

This works as expected.

To store the permission I could simply use an "item" (table item) and there the colums allow_cid,...
I could sync it to the clones. It would be included in import/export.

Is this a way you would go?

Einer von Vielen

Tue, 05 May 2020 03:17:57 -0700

still trying to understand how I could use PermissionLimits.php (pconfig) > Permcat.php to allow specically a user or group to view the addon for a channel. Hmm.

Mike Macgirvin

Tue, 05 May 2020 03:23:52 -0700

That's kind of a "poor man's" approach but it should work. You can store this anywhere.

You can also add the permission to the permissions system and federate it across other systems. But I'll warn you that this is very hard and will be quite different between Hubzilla and Zap. It's *really* hard in Hubzilla.

So the "poor man's" approach isn't bad considering the options. If you'd like to look at extending permissions in Zap, I'd suggest going back through the zap-addons repository to a point before I deleted the wiki addon. This created and managed new permissions through a plugin. If I recall the permissions part involved 6-7 different hooks and the code for each one wasn't horrible (mostly just adding the new permission names to various lists) but altogether it was a bit fiddly.

Einer von Vielen

Tue, 05 May 2020 07:39:25 -0700

@Zap @Mike Macgirvin

I'd suggest going back through the zap-addons repository to a point before I deleted the wiki addon

Ah, yes, I knew it did see it somewhere.

I go for the "poor man's" approach, mainly to keep compatibility with Hubzilla.

(On the other hand it is not the "perfect" approach. And, others and me "loose" an example to learn and/or copy from.)

Many thanks for your patience.